mkevo commented on a change in pull request #6351:
URL: https://github.com/apache/geode/pull/6351#discussion_r647165213



##########
File path: 
geode-lucene/src/upgradeTest/java/org/apache/geode/cache/lucene/RollingUpgradeQueryReturnsCorrectResultsAfterClientAndServersAreRolledOverAllBucketsCreated.java
##########
@@ -31,6 +32,7 @@
 public class 
RollingUpgradeQueryReturnsCorrectResultsAfterClientAndServersAreRolledOverAllBucketsCreated
     extends LuceneSearchWithRollingUpgradeDUnit {
 
+  @Ignore

Review comment:
       What did you mean by this logic to determine the expected behaviour of 
the query based on the Geode version?  In versions before Lucene is upgraded, 
the test(always doing the upgrade to the newest version) is not changed and it 
works. Maybe you think that we need this change for the future version of Geode 
when Lucene format will be the same, and test between that versions should work 
as before this changes? Or you mean something else?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to