DonalEvans commented on pull request #6351: URL: https://github.com/apache/geode/pull/6351#issuecomment-856853906
> > Having thought about these changes some more, I'm wondering if it's necessary to be quite so strict with the Geode version check (such as in IndexRepositoryFactory and LuceneEventListener). Certainly on the current develop branch, any older version of Geode will cause problems if a Lucene query is attempted, but once 1.15.0 has been released, there should be no problem with rolling from 1.15.0 to a newer version, providing the Lucene version hasn't changed again. It might be better to instead check that there is no member older than the version in which Lucene was updated (1.15.0, assuming we don't cut the release branch before these changes are merged). I understand that this would be more work, and would mean that RollingUpgrade tests would become more complex, as they'd have to cover both the failing and passing cases, but if you agree that there would be value in only preventing Lucene queries when we know there's a potential problem rather than the more blunt approach cur rently used, then I'd appreciate the change. > > Yes, there should no be a problem with rolling upgrade to a newer version once 1.15.0 is released, until there are no format changes in new Lucene versions. > Maybe we can change tests to have some check to see if there is a member older than 1.15.0, and regarding the result run query or ignore it until all members are on a version where Lucene was updated, or newer. Yeah, I think this would be the best course of action. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
