sabbey37 commented on a change in pull request #6573:
URL: https://github.com/apache/geode/pull/6573#discussion_r647555479
##########
File path:
geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/sortedset/AbstractZAddIntegrationTest.java
##########
@@ -35,12 +35,17 @@
import redis.clients.jedis.Protocol;
import redis.clients.jedis.params.ZAddParams;
+import org.apache.geode.redis.ConcurrentLoopingThreads;
import org.apache.geode.redis.RedisIntegrationTest;
import org.apache.geode.redis.internal.RedisConstants;
+import org.apache.geode.redis.internal.netty.Coder;
import org.apache.geode.test.awaitility.GeodeAwaitility;
public abstract class AbstractZAddIntegrationTest implements
RedisIntegrationTest {
private JedisCluster jedis;
+ private final String member = "member";
+ private final String incrOption = "INCR";
+
private static final int REDIS_CLIENT_TIMEOUT =
Review comment:
Oooh we also have the `REDIS_CLIENT_TIMEOUT` variable defined in
`RedisClusterStartupRule` which is in the `commonTest` module... so we could
potentially remove it from `RedisIntegrationTest` altogether.
On line 57 below this we use "localhost" when starting the JedisCluster, we
could import the `BIND_ADDRESS` variable from `RedisClusterStartupRule` and use
that instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
