kirklund commented on a change in pull request #6460:
URL: https://github.com/apache/geode/pull/6460#discussion_r647860202
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
##########
@@ -8075,8 +8075,12 @@ public DistributionAdvisee getParentAdvisee() {
private final long maxTimeInRetry;
- public RetryTimeKeeper(int maxTime) {
- this.maxTimeInRetry = maxTime;
+ public RetryTimeKeeper(int maxTimeInRetry) {
+ this.maxTimeInRetry = maxTimeInRetry;
+ }
+
Review comment:
It's not required. I added `public RetryTimeKeeper(long maxTimeInRetry)`
because most millis are in long and the caller has to downcast with `(int)`
which causes a warning in IntelliJ, and I was trying to reduce the number of
warnings.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
##########
@@ -8075,8 +8075,12 @@ public DistributionAdvisee getParentAdvisee() {
private final long maxTimeInRetry;
- public RetryTimeKeeper(int maxTime) {
- this.maxTimeInRetry = maxTime;
+ public RetryTimeKeeper(int maxTimeInRetry) {
+ this.maxTimeInRetry = maxTimeInRetry;
+ }
+
Review comment:
I added `public RetryTimeKeeper(long maxTimeInRetry)` because most
millis are in long and the caller has to downcast with `(int)` which causes a
warning in IntelliJ, and I was trying to reduce the number of warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
