alb3rtobr commented on a change in pull request #6597:
URL: https://github.com/apache/geode/pull/6597#discussion_r648715360



##########
File path: geode-docs/getting_started/intro_to_clients.html.md.erb
##########
@@ -0,0 +1,353 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.  See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+<% set_title("Introduction to", product_name, "Clients") %>
+
+This section provides basic starting points for a variety of 
<%=vars.product_name %> clients, along
+with very rudimentary connect, put, get, and then a reference to more in-depth 
docs and examples on
+how to use the client.
+
+## Installing Apache Geode
+
+You can download Apache Geode from the website, run a Docker image, or install 
with homebrew on OSX.
+
+## Start an Apache Geode Cluster
+
+With a path that contains the bin directory of the installation, start a 
locator and server.

Review comment:
       > With a path that contains the bin directory of the installation
   If Geode is installed, this should be already configured so I think it is 
not necessary to say this. Actually, you could run gfsh without adding it to 
the path.
   
   I would write something like: "As a first step for running these examples, 
we need to start an Apache Geode cluster that will be composed by a locator and 
a server"

##########
File path: geode-docs/getting_started/intro_to_clients.html.md.erb
##########
@@ -0,0 +1,353 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.  See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+<% set_title("Introduction to", product_name, "Clients") %>
+
+This section provides basic starting points for a variety of 
<%=vars.product_name %> clients, along
+with very rudimentary connect, put, get, and then a reference to more in-depth 
docs and examples on
+how to use the client.
+
+## Installing Apache Geode
+
+You can download Apache Geode from the website, run a Docker image, or install 
with homebrew on OSX.
+
+## Start an Apache Geode Cluster
+
+With a path that contains the bin directory of the installation, start a 
locator and server.

Review comment:
       > With a path that contains the bin directory of the installation
   
   If Geode is installed, this should be already configured so I think it is 
not necessary to say this. Actually, you could run gfsh without adding it to 
the path.
   
   I would write something like: "As a first step for running these examples, 
we need to start an Apache Geode cluster that will be composed by a locator and 
a server"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to