DonalEvans commented on a change in pull request #6590:
URL: https://github.com/apache/geode/pull/6590#discussion_r649583861
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/collections/SizeableObject2ObjectOpenCustomHashMapWithCursor.java
##########
@@ -29,52 +33,58 @@
* The scan method provides the same guarantees as Redis's HSCAN, and in fact
* uses the same algorithm.
*/
-public class Object2ObjectOpenCustomHashMapWithCursor<K, V>
- extends Object2ObjectOpenCustomHashMap<K, V> {
+public class SizeableObject2ObjectOpenCustomHashMapWithCursor<K, V>
Review comment:
We currently have [a PR up](https://github.com/apache/geode/pull/6548)
that uses a non-byte[] value in the CustomHashMap implementation, so I don't
want to conflict with that by changing the underlying data structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
