DonalEvans commented on a change in pull request #6596:
URL: https://github.com/apache/geode/pull/6596#discussion_r650180123
##########
File path:
geode-core/src/integrationTest/java/org/apache/geode/internal/cache/OplogRVVJUnitTest.java
##########
@@ -75,6 +75,7 @@ public void testRecoverRVV() {
final DiskStoreID m1 = DiskStoreID.random();
final DiskStoreID m2 = DiskStoreID.random();
final DiskRecoveryStore drs = mock(DiskRecoveryStore.class);
+ when(parent.getWriteBufferSize()).thenReturn(32768);
Review comment:
Could hard-coded uses of this value (when it relates to Oplog buffer
sizes) be replaced with references to
`DiskStoreFactory.DEFAULT_WRITE_BUFFER_SIZE`?
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
##########
@@ -1093,13 +1094,26 @@ private void createCrf(OplogFile prevOlf) throws
IOException {
this.maxCrfSize += this.crf.currSize;
}
- private static ByteBuffer allocateWriteBuf(OplogFile prevOlf) {
+ @VisibleForTesting
+ boolean writeBufferSizeSystemPropertyIsDefined() {
+ return (Integer.getInteger("WRITE_BUF_SIZE") != null);
Review comment:
Could the `WRITE_BUF_SIZE` String be pulled out into a constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
