DonalEvans commented on a change in pull request #6595:
URL: https://github.com/apache/geode/pull/6595#discussion_r653835620
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/Coder.java
##########
@@ -78,18 +78,16 @@
public static final byte[] bEMPTY_STRING = stringToBytes("$0\r\n\r\n");
@MakeImmutable
- public static final byte[] err = stringToBytes("ERR ");
+ public static final byte[] ERR = stringToBytes("ERR ");
@MakeImmutable
- public static final byte[] oom = stringToBytes("OOM ");
+ public static final byte[] MOVED = stringToBytes("MOVED ");
Review comment:
After rebasing, could this be moved to the `StringBytesGlossary` class
and renamed to be consistent with other constants in that class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
