DonalEvans commented on a change in pull request #6616:
URL: https://github.com/apache/geode/pull/6616#discussion_r655773434
##########
File path:
geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/AbstractSubCommandsIntegrationTest.java
##########
@@ -191,6 +201,67 @@ public void
channels_shouldNotReturnDuplicates_givenMultipleSubscribersToSameCha
subscriber2.close();
}
+ /** -- NUMSUB-- **/
+
+ @Test
+ public void numsub_shouldReturnEmptyList_whenCalledWithOutChannelNames() {
+ executor.submit(() -> subscriber.subscribe(mockSubscriber, "foo"));
+ waitFor(() -> mockSubscriber.getSubscribedChannels() == 1);
+
+ List<Object> result =
+ uncheckedCast(introspector.sendCommand(Protocol.Command.PUBSUB,
PUBSUB_NUMSUB));
+
+ assertThat(result).isEmpty();
+ }
+
+ @Test
+ public void
numsub_shouldReturnListOfChannelsWithSubscriberCount_whenCalledWithActiveChannels()
{
+ Jedis subscriber2 = new Jedis(BIND_ADDRESS, getPort(),
REDIS_CLIENT_TIMEOUT);
+ MockSubscriber fooAndBarSubscriber = new MockSubscriber();
+
+ executor.submit(() -> subscriber.subscribe(mockSubscriber, "foo"));
+ executor.submit(() -> subscriber2.subscribe(fooAndBarSubscriber, "foo",
"bar"));
+ waitFor(() -> mockSubscriber.getSubscribedChannels() == 1
+ && fooAndBarSubscriber.getSubscribedChannels() == 2);
+
+ HashMap<String, String> result =
+ (HashMap<String, String>) introspector.pubsubNumSub("foo", "bar");
+
+ assertThat(result.containsKey("foo")).isTrue();
+ assertThat(result.containsKey("bar")).isTrue();
+ assertThat(result.get("foo")).isEqualTo("2");
+ assertThat(result.get("bar")).isEqualTo("1");
+
+ fooAndBarSubscriber.unsubscribe();
+
+ waitFor(() -> fooAndBarSubscriber.getSubscribedChannels() == 0);
+ subscriber2.close();
+ }
+
+ @Test
+ public void
numsub_shouldReturnChannelNameWithZero_whenCalledWithChannelWithNoSubscribers()
{
+ executor.submit(() -> subscriber.subscribe(mockSubscriber, "foo"));
+ waitFor(() -> mockSubscriber.getSubscribedChannels() == 1);
+
+ HashMap<String, String> result =
+ (HashMap<String, String>) introspector.pubsubNumSub("bar");
+
+ assertThat(result.containsKey("bar")).isTrue();
+ assertThat(result.get("bar")).isEqualTo("0");
+ }
+
+ @Test
+ public void
numsub_shouldReturnPatternWithZero_whenCalledWithPatternWithNoChannelSubscribers()
{
Review comment:
Yep, looks good, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
