DonalEvans commented on a change in pull request #6625:
URL: https://github.com/apache/geode/pull/6625#discussion_r656405637
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/TXCommitMessage.java
##########
@@ -416,8 +416,10 @@ void send(TXLockId lockId) {
setRecipientsSendData(Collections.singleton(indivRecip.next()), processor, rcl);
}
} else {
- Set<InternalDistributedMember> tempNotificationOnlyMembers = new
HashSet();
- Set<InternalDistributedMember> tempTransactionMembers = new
HashSet();
+ Set<InternalDistributedMember> tempNotificationOnlyMembers =
+ new HashSet<InternalDistributedMember>();
+ Set<InternalDistributedMember> tempTransactionMembers =
+ new HashSet<InternalDistributedMember>();
Review comment:
These should just be `new HashSet<>();` with the angle brackets present
but empty. It's not necessary to specify the type as part of the constructor,
as it's implicit from the `Set<InternalDistributedMember>` declaration, but
it's still necessary to use empty angle brackets to show that the `HashSet` is
parameterized. This comment also applies to the other changes in this commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
