gesterzhou commented on a change in pull request #6625:
URL: https://github.com/apache/geode/pull/6625#discussion_r656602740
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/TXRegionState.java
##########
@@ -319,32 +319,55 @@ void buildMessage(InternalRegion r, TXCommitMessage msg) {
try {
if (!r.getScope().isLocal() && !this.entryMods.isEmpty()) {
- msg.startRegion(r, entryMods.size());
- Iterator it = this.entryMods.entrySet().iterator();
- Set<InternalDistributedMember> newMemberSet = new
HashSet<InternalDistributedMember>();
+ TXCommitMessage.RegionCommit regionCommit = msg.startRegion(r,
entryMods.size());
+ Set<InternalDistributedMember> newMemberSet = new HashSet<>();
+ Set<InternalDistributedMember> redundantMemberSet =
+ new HashSet<>();
if (r.getScope().isDistributed()) {
DistributedRegion dr = (DistributedRegion) r;
msg.addViewVersion(dr, dr.getDistributionAdvisor().startOperation());
- newMemberSet.addAll(dr.getCacheDistributionAdvisor().adviseTX());
+ Set<InternalDistributedMember> advice =
dr.getCacheDistributionAdvisor().adviseTX();
+ newMemberSet.addAll(advice);
+ redundantMemberSet.addAll(advice);
+ if (!redundantMemberSet.isEmpty()) {
+ if (msg.getTransactionMembers().get(regionCommit) == null) {
+ msg.getTransactionMembers().put(regionCommit,
redundantMemberSet);
+ } else {
+
msg.getTransactionMembers().get(regionCommit).addAll(redundantMemberSet);
+ }
+ }
}
+ Iterator it = this.entryMods.entrySet().iterator();
+
while (it.hasNext()) {
Map.Entry me = (Map.Entry) it.next();
Object eKey = me.getKey();
TXEntryState txes = (TXEntryState) me.getValue();
txes.buildMessage(r, eKey, msg, this.otherMembers);
if (txes.getFilterRoutingInfo() != null) {
+ Set<InternalDistributedMember> tempSet = new HashSet<>();
Review comment:
the tempSet should be renamed to be tempNotificationOnlyMembers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
