todmorrison commented on a change in pull request #6629:
URL: https://github.com/apache/geode/pull/6629#discussion_r657407079
##########
File path:
geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxToJSON.java
##########
@@ -226,7 +225,8 @@ private void getJSONStringFromArray(JsonGenerator jg,
Object value, String pf)
jg.writeEndArray();
} else {
throw new IllegalStateException(
- "PdxInstance returns unknown pdxfield " + pf + " for type " + value);
+ "PdxInstance returns unsupported type " + value.getClass()
Review comment:
*I* like this better:
```
} else if (value.getClass().isArray()) {
throw new IllegalStateException(
"The pdx field " + pf + " is an array whose component type "
+ value.getClass().getComponentType()
+ " can not be converted to JSON.");
} else {
throw new IllegalStateException(
"Expected an array for pdx field " + pf + ", but got an object of
type "
+ value.getClass());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
