pivotal-jbarrett commented on a change in pull request #825:
URL: https://github.com/apache/geode-native/pull/825#discussion_r658833863
##########
File path: clicache/src/impl/PdxFieldType.cpp
##########
@@ -166,23 +166,23 @@ namespace Apache
switch (m_typeId)
{
case PdxFieldTypes::BYTE:
- return PdxTypes::BYTE_SIZE;
+ return PdxTypes::PDX_BYTE_SIZE;
Review comment:
If you are changing these then we should be changing them to match the
style guide we currently have approved. In our last discussion about the style
guide we did not agree on a deviation for enum names. By using prescribed
naming convention you will avoid the macro name collision.
https://google.github.io/styleguide/cppguide.html#Enumerator_Names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
