aaronlindsey commented on a change in pull request #6665:
URL: https://github.com/apache/geode/pull/6665#discussion_r661885047
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/util/ManagementUtils.java
##########
@@ -162,14 +163,20 @@ public static DistributedMember
getDistributedMemberByNameOrId(String memberName
Set<Region<?, ?>> rootRegions = cache.rootRegions();
for (Region<?, ?> rootRegion : rootRegions) {
- regionNames.add(rootRegion.getFullPath().substring(1));
+ try {
+ Set<Region<?, ?>> subRegions = rootRegion.subregions(true);
- Set<Region<?, ?>> subRegions = rootRegion.subregions(true);
+ for (Region<?, ?> subRegion : subRegions) {
+ regionNames.add(subRegion.getFullPath().substring(1));
+ }
- for (Region<?, ?> subRegion : subRegions) {
- regionNames.add(subRegion.getFullPath().substring(1));
+ } catch (RegionDestroyedException ignored) {
Review comment:
It's not the only exception this block can throw. I like your suggestion
of catching general `Exception`. Would it be OK to log the caught exception as
"debug" level? (My main purpose with this change is to prevent
RegionDestroyedException from showing up in the logs under normal conditions
when it is thrown from this function.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
