gaussianrecurrence commented on a change in pull request #806:
URL: https://github.com/apache/geode-native/pull/806#discussion_r662174497
##########
File path: cppcache/integration/test/PdxTypeRegistryTest.cpp
##########
@@ -140,19 +141,60 @@ TEST(PdxTypeRegistryTest, cleanupOnClusterRestart) {
listener->waitConnected();
- key = "after-restart";
- region->put(key, createTestPdxInstance(cache, key));
+ region->put(key, pdx);
// If PdxTypeRegistry was cleaned up, then the PdxType should have been
// registered in the new cluster
std::shared_ptr<SelectResults> result;
- auto query =
- qs->newQuery("SELECT * FROM /region WHERE entryName = '" + key + "'");
+ auto query = qs->newQuery("SELECT * FROM /region WHERE int_value = -1");
EXPECT_NO_THROW(result = query->execute());
EXPECT_TRUE(result);
- EXPECT_GT(result->size(), 0);
+ EXPECT_EQ(result->size(), 1);
Review comment:
You've got a pretty good point. I've got so many changes in my head that
by mistake I changed this test behaviour. This was working fine as it was. I'll
revert this test changes. Also, what do you think about adding some comments to
clarify how these tests works? I mean cleanupOnClusterRestart and
cleanupOnClusterRestartAndFetchFields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
