jdeppe-pivotal commented on a change in pull request #6670:
URL: https://github.com/apache/geode/pull/6670#discussion_r664886776



##########
File path: 
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/collections/OrderStatisticsTree.java
##########
@@ -205,6 +205,32 @@ public boolean add(E element) {
     return true;
   }
 
+  public ArrayList<E> getIndexRange(int min, int max) {
+    ArrayList<E> entryList = new ArrayList<>();
+    Node<E> current = getNode(min);
+    for (int i = min; current != null && i <= max; i++) {
+      entryList.add(current.key);

Review comment:
       OK - I just wouldn't want that to get lost. Another option is to return 
an `Iterator` here. It seems fairly trivial to augment the internal 
`TreeIterator` with a 'limit'. Anyway, your call.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to