pivotal-jbarrett commented on a change in pull request #830:
URL: https://github.com/apache/geode-native/pull/830#discussion_r665671236
##########
File path: cppcache/src/ThinClientRegion.cpp
##########
@@ -589,7 +595,7 @@ std::shared_ptr<SelectResults> ThinClientRegion::query(
}
std::string squery;
- if (std::regex_search(predicate, PREDICATE_IS_FULL_QUERY_REGEX)) {
+ if (std::regex_search(predicate, IsFullQueryRegex::instance())) {
Review comment:
I am not quite following this argument since it seems to argue for both
options. The Meyers singleton won't initialize the static until first use so
there is no burden to the test harness as a whole.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
