DonalEvans commented on a change in pull request #6699:
URL: https://github.com/apache/geode/pull/6699#discussion_r670865597
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/collections/SizableOrderStatisticsTree.java
##########
@@ -731,6 +741,25 @@ private int count(Node<E> node) {
return leftTreeSize + 1 + rightTreeSize;
}
+ void updateSizeInBytes(E element, boolean isAdd) {
+ int sizeChange;
+ if (element instanceof Sizeable) {
Review comment:
I don't think we do this anywhere else, but I did it here to avoid
having to use ReflectionSingleObjectSizer for objects that are already keeping
track of their size, since that would reduce overhead (I think). Your
suggestion is a good one though, so I'll implement it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
