jdeppe-pivotal commented on a change in pull request #6700:
URL: https://github.com/apache/geode/pull/6700#discussion_r671307115
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSetCommandsFunctionExecutor.java
##########
@@ -62,6 +62,13 @@ public long zcount(RedisKey key, SortedSetRangeOptions
rangeOptions) {
() -> getRedisSortedSet(key, true).zrange(min, max, withScores));
}
+ @Override
+ public List<byte[]> zrangebyscore(RedisKey key, SortedSetRangeOptions
rangeOptions,
+ boolean withScores) {
+ return stripedExecute(key,
+ () -> getRedisSortedSet(key, true).zrangebyscore(rangeOptions,
withScores));
Review comment:
I believe that Redis' approach is to update the stats for commands that
don't update data. In your sample list, `zrange` actually does call it with
`true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
