dschneider-pivotal commented on a change in pull request #6716:
URL: https://github.com/apache/geode/pull/6716#discussion_r675670823
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/StringBytesGlossary.java
##########
@@ -175,12 +175,13 @@
@MakeImmutable
public static final byte[] bABSTTL = stringToBytes("ABSTTL");
- // AbstractZRangeExecutor
+ // Various ZRangeExecutors
@MakeImmutable
public static final byte[] bWITHSCORES = stringToBytes("WITHSCORES");
-
@MakeImmutable
public static final byte[] bLIMIT = stringToBytes("LIMIT");
+ public static final byte bPLUS = SIMPLE_STRING_ID; // +
Review comment:
I can see the danger of having byte arrays that you want to be
constants. In fact any array that you want to treat as a constant could be an
issue because arrays can always be modified. It looks like we have marked them
all as MakeImmutable which serves as a warning that they should not be
modified.
For constants I'm used to all upper case and underscores so the lowercase
prefix is not helpful to me. I'm open to it if it actually has a specific
meaning. When I first saw it I thought we were encoding type info in the
symbolic name and if so I don't see a need for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
