pivotal-jbarrett commented on a change in pull request #6721: URL: https://github.com/apache/geode/pull/6721#discussion_r679299752
########## File path: geode-core/src/main/java/org/apache/geode/security/AuthenticationExpiredException.java ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.geode.security; + +/** + * This exception is thrown by the SecurityManager's authorize method to indicate that the + * authentication has expired. + */ Review comment: Nope. Exceptions on an interface are optional on the implementation. Checked exceptions are no exception. 🥁 Current implementations will both compile and run without issue. This particular interface is an SPI which means the only callers of this API are internal to Geode, meaning only Geode code would be subject to the checked exception being handled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
