pivotal-jbarrett commented on a change in pull request #6702:
URL: https://github.com/apache/geode/pull/6702#discussion_r679334897
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GatewayReceiverCommand.java
##########
@@ -793,24 +784,12 @@ private static void writeBatchException(Message origMsg,
List<BatchException70>
}
private static void writeFatalException(Message origMsg, Throwable exception,
- ServerConnection servConn, int batchId) throws IOException {
+ ServerConnection servConn) throws IOException {
Message errorMsg = servConn.getErrorResponseMessage();
errorMsg.setMessageType(MessageType.EXCEPTION);
errorMsg.setNumberOfParts(2);
errorMsg.setTransactionId(origMsg.getTransactionId());
-
- // For older gateway senders, we need to send back an exception
- // they can deserialize.
- if ((servConn.getClientVersion() == null
Review comment:
As it turns out it can never be `null` from
`ServerConnection.getClientVersion()`. The implementation would explode with
exceptions if it were. Would you like me to annotate `@NotNull` through this
path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
