demery-pivotal commented on pull request #6748: URL: https://github.com/apache/geode/pull/6748#issuecomment-896141294
> Odd that this is the first we have seen of this kind of problem. One would have thought other default ports would have this problem. It's a consequence of two things. First, we are no longer dockerizing test workers. Until a few weeks ago, each test worker ran in a separate docker container, and within each container fewer processes were competing for ports. Now that dozens of concurrently running tests compete for the same ports, we will see more port conflicts like this. Second, very few tests use default ports, so there are likely to be few conflicts… except in stress tests, which pit multiple instances of a test against each other. > But perhaps, this test is flawed. Perhaps breaking it into a test of the default port number and a test of the starting up on a specified port would be more appropriate then altering our test framework? I chose this approach because it affects only tests that explicitly test the use of default ports. And my guess (or perhaps merely my hope) is that very few tests do that: Only one per service. So very few tests will use this technique to avoid stress. I hope. As for altering the test framework, my assessment (for now) is that including these few tests in stress test runs isn't worth the extra complexity in the test framework. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
