ringles commented on a change in pull request #6715:
URL: https://github.com/apache/geode/pull/6715#discussion_r686289704



##########
File path: 
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSet.java
##########
@@ -272,12 +272,12 @@ long zcard() {
   }
 
   long zcount(SortedSetScoreRangeOptions rangeOptions) {
-    AbstractOrderedSetEntry minEntry = new 
ScoreDummyOrderedSetEntry(rangeOptions.getMinimum(),
-        rangeOptions.isMinExclusive(), true);
+    AbstractOrderedSetEntry minEntry = new 
ScoreDummyOrderedSetEntry(rangeOptions.getStartRange(),

Review comment:
       Didn't do it _quite_ that way, but extracted a couple methods that 
indeed can be used in several places. Good catch; hope this is along the lines 
of your thinking...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to