ringles commented on a change in pull request #6735:
URL: https://github.com/apache/geode/pull/6735#discussion_r687077100



##########
File path: 
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSet.java
##########
@@ -357,6 +357,27 @@ long zcount(SortedSetScoreRangeOptions rangeOptions) {
     return addLimitToRange(rangeOptions, withScores, minIndex, maxIndex);
   }
 
+  long zlexcount(SortedSetLexRangeOptions lexOptions) {
+    // Assume that all members have the same score. Behaviour is unspecified 
otherwise.
+    double score = scoreSet.get(0).score;
+
+    AbstractOrderedSetEntry minEntry = new 
MemberDummyOrderedSetEntry(lexOptions.getMinimum(),

Review comment:
       If I can get the ZREVRANGEBYSCORE PR pushed up, we can use the helper 
methods I added there.

##########
File path: 
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/NullRedisSortedSet.java
##########
@@ -63,6 +63,11 @@ long zcount(SortedSetScoreRangeOptions rangeOptions) {
     return 0;
   }
 
+  @Override

Review comment:
       Again, alphabetizing is apparently what we're doing here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to