pivotal-jbarrett commented on a change in pull request #839:
URL: https://github.com/apache/geode-native/pull/839#discussion_r688038621
##########
File path: ci/base/base.yml
##########
@@ -19,6 +19,7 @@
#@ def new_build(name, package="Linux-64bit.tar.gz"):
name: #@ name
with_dot_net: #@ False
+with_netcore: #@ True
Review comment:
Since all platforms we support have it what is the point in making it
configurable in the CI right now?
##########
File path: netcore/CMakeLists.txt
##########
@@ -0,0 +1,27 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+project(netcore LANGUAGES NONE)
+
+option(INCLUDE_DOTNET_CORE "Build .NET Core client." ON)
+
+find_program(DOTNET dotnet)
+
+if(DOTNET AND INCLUDE_DOTNET_CORE)
+ add_custom_target(netcore ALL COMMAND ${DOTNET} build --configuration
$<CONFIG> WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/NetCore DEPENDS
apache-geode-c VERBATIM)
+ add_custom_target(netcore-test ALL COMMAND ${DOTNET} build --configuration
$<CONFIG> WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/NetCore.Test DEPENDS
netcore VERBATIM)
+
+ install(FILES
${CMAKE_CURRENT_SOURCE_DIR}/NetCore/bin/$<CONFIG>/netcoreapp3.1/Apache.Geode.NetCore.dll
DESTINATION ./lib)
Review comment:
Do all .NET core assemblies have .dll suffixes on all platforms? In
Windows it was the norm for .dll files to go in the bin directory since they
have to be in the runtime path. Is that not the case anymore? What about on
other platforms, do they search the runtime path or the library path?
##########
File path: ci/lib/templates.lib.yml
##########
@@ -221,6 +222,9 @@ plan:
- #@ remote_task("net-integration-tests", config.config,
ctest_bash_task("build/clicache/integration-test2"), "1h", build.params)
- #@ remote_task("net-legacy-integration-tests", config.config,
ctest_bash_task("build/clicache/integration-test", timeout=500, parallel=4),
"2h", build.params)
#@ end
+ #@ if build.with_netcore:
+ - #@ remote_task("netcore-tests", config.config,
dotnet_bash_task("netcore/Netcore.Test"), "2h", build.params)
Review comment:
Do the tests really take up to 2 hours to run?
##########
File path: packer/build-windows-2016-vs-2017.json
##########
@@ -92,7 +92,8 @@
"choco install doxygen.install -confirm",
"choco install openssl -confirm",
"choco install strawberryperl -confirm",
- "choco install nuget.commandline -confirm"
+ "choco install nuget.commandline -confirm",
+ "choco install dotnetcore-sdk -confirm"
Review comment:
Don't we need to pin this to a specific version or are all the versions
capable of compiling to the LTS version level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
