mmartell commented on a change in pull request #841:
URL: https://github.com/apache/geode-native/pull/841#discussion_r689708500
##########
File path: ci/base/base.yml
##########
@@ -61,7 +61,7 @@ builds:
with_dot_net: #@ True
#@yaml/map-key-override
params:
- CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv141,version=14.16,host=x64
-DCMAKE_SYSTEM_VERSION=10.0.16299.0"
Review comment:
I don't think we need this anymore. I'm able to build fine using VS 2017
without it. I've verified that my local build was using the 32 bit linker, and
everything still builds and all tests pass. When I do a dumpbin /headers on the
32 bit linker, I see:
"Application can handle large (>2GB) addresses"
Maybe this has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
