jchen21 commented on a change in pull request #6756:
URL: https://github.com/apache/geode/pull/6756#discussion_r690569619
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/lang/SystemPropertyHelper.java
##########
@@ -71,6 +71,9 @@
public static final String USE_HTTP_SYSTEM_PROPERTY = "useHTTP";
+ public static final String ENABLE_QUERY_RETRY_ON_PDX_SERIALIZATION_EXCEPTION
=
Review comment:
Better add some comments for the new system property. Add what is the
default value for this property?
##########
File path:
geode-core/src/test/java/org/apache/geode/internal/lang/SystemPropertyHelperTest.java
##########
@@ -107,6 +107,17 @@ public void
getBooleanPropertyReturnsGemfirePrefixIfGeodeMissing() {
System.clearProperty(gemfirePrefixProperty);
}
+ @Test
+ public void
getBooleanPropertyReturnsEnableRetryOnPdxSerializationException() {
+ String testProperty = "enableQueryRetryOnPdxSerializationException";
+ String gemfirePrefixProperty = "gemfire." + testProperty;
Review comment:
Better add additional test with `geode.` prefix as property name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
