dschneider-pivotal commented on a change in pull request #6766:
URL: https://github.com/apache/geode/pull/6766#discussion_r690666620
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/sortedset/SortedSetLexRangeOptions.java
##########
@@ -83,13 +83,19 @@ void handleWithScoresArgument() {
@Override
int compareStartToEnd() {
if (isRev) {
- // TODO: implement ZREVRANGEBYLEX
- }
- int dummyNameComparison = checkDummyMemberNames(start.value, end.value);
- if (dummyNameComparison == 0) {
- return javaImplementationOfAnsiCMemCmp(start.value, end.value);
+ int dummyNameComparison = checkDummyMemberNames(end.value, start.value);
Review comment:
consider extracting this block of code into a method that take two
values. Then all you need to do differently (based on isRev) is pass it
end+start vs. start+end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
