jdeppe-pivotal commented on a change in pull request #6725:
URL: https://github.com/apache/geode/pull/6725#discussion_r690489701
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java
##########
@@ -176,8 +176,8 @@ public void initChannel(SocketChannel socketChannel) {
pipeline.addLast(new WriteTimeoutHandler(10));
pipeline.addLast(ExecutionHandlerContext.class.getSimpleName(),
new ExecutionHandlerContext(socketChannel, regionProvider, pubsub,
- allowUnsupportedSupplier, shutdownInvoker, redisStats,
backgroundExecutor,
- redisPasswordBytes, getPort(), member));
+ allowUnsupportedSupplier, shutdownInvoker, redisStats,
redisPasswordBytes,
Review comment:
The `backgroundExecutor` removed here should also be removed from the
constructor and can then also be removed from `GeodeRedisServer`.
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -94,7 +94,7 @@ public GeodeRedisServer(String bindAddress, int port,
InternalCache cache) {
nettyRedisServer = new NettyRedisServer(() ->
cache.getInternalDistributedSystem().getConfig(),
regionProvider, pubSub,
this::allowUnsupportedCommands, this::shutdown, port, bindAddress,
redisStats,
- redisCommandExecutor, member);
+ member);
Review comment:
This executor can be completely removed from the class now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
