mhansonp commented on a change in pull request #6755:
URL: https://github.com/apache/geode/pull/6755#discussion_r692552257



##########
File path: 
geode-core/src/upgradeTest/java/org/apache/geode/security/AuthExpirationDUnitTest.java
##########
@@ -85,9 +86,10 @@ public void 
clientShouldReAuthenticateWhenCredentialExpiredAndOperationSucceed()
     clientVM.invoke(() -> {
       ClientCache clientCache = ClusterStartupRule.getClientCache();
       UpdatableUserAuthInitialize.setUser("user1");
-      ClientRegionFactory clientRegionFactory =
+      assert clientCache != null;

Review comment:
       I'm of the mindset that an assertThat(clientCache).isNotNull(); would be 
better than what is there. That is pretty much the standard in tests. Whether 
it is to clear a warning or not. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to