jinmeiliao commented on a change in pull request #6787:
URL: https://github.com/apache/geode/pull/6787#discussion_r694213532
##########
File path:
geode-core/src/main/java/org/apache/geode/security/SecurityManager.java
##########
@@ -74,8 +74,11 @@ default void init(Properties securityProps) {}
* @param principal The principal that's requesting the permission
* @param permission The permission requested
* @return true if authorized, false if not
+ *
+ * @throw AuthenticationExpiredException if the principal has expired.
*/
- default boolean authorize(Object principal, ResourcePermission permission) {
+ default boolean authorize(Object principal, ResourcePermission permission)
+ throws AuthenticationExpiredException {
Review comment:
No, adding exception wouldn't. this is from Oracle java doc site:
13.4.21. Method and Constructor Throws
Changes to the throws clause of methods or constructors do not break
compatibility with pre-existing binaries; these clauses are checked only at
compile time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
