gaussianrecurrence commented on a change in pull request #6737:
URL: https://github.com/apache/geode/pull/6737#discussion_r694660792
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/process/FileProcessController.java
##########
@@ -77,6 +77,37 @@
this.statusTimeoutMillis = units.toMillis(timeout);
}
+ /**
+ * Constructs an instance for controlling a local process.
+ *
+ * @param parameters details about the controllable process
+ *
+ * @throws IllegalArgumentException if pid is not a positive integer
+ */
+ FileProcessController(final FileControllerParameters parameters) {
+ this(parameters, DEFAULT_STATUS_TIMEOUT_MILLIS, MILLISECONDS);
+ }
+
+ /**
+ * Constructs an instance for controlling a local process.
+ *
+ * @param parameters details about the controllable process
+ * @param timeout the timeout that operations must complete within
+ * @param units the units of the timeout
+ *
+ * @throws IllegalArgumentException if pid is not a positive integer
Review comment:
Thanks for pointing this out. Change done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
