upthewaterspout commented on a change in pull request #6746:
URL: https://github.com/apache/geode/pull/6746#discussion_r696016207
##########
File path:
geode-assembly/geode-assembly-test/src/main/java/org/apache/geode/test/junit/rules/GeodeDevRestClient.java
##########
@@ -156,7 +156,10 @@ public HttpResponse doRequest(HttpRequestBase request,
String username, String p
return clientBuilder.build().execute(host, request, clientContext);
} catch (Exception e) {
- throw new RuntimeException(e.getMessage(), e);
+ throw new RuntimeException(
+ String.format("Request %s' with username '%s' password '%s' failed",
request, username,
Review comment:
Not sure why this message changed, but we shouldn't be logging a
password or including it in exceptions.
##########
File path:
geode-dunit/src/main/java/org/apache/geode/test/dunit/rules/CacheXmlRule.java
##########
@@ -47,9 +46,9 @@
private static final String BEFORE = "before";
private static final String AFTER = "after";
- private static final CacheXmlCreation DUMMY = mock(CacheXmlCreation.class);
+ private static final CacheXmlCreation DUMMY = new CacheXmlCreation(null,
null);
private static final AtomicReference<ICacheXmlCreation> DELEGATE = new
AtomicReference<>(DUMMY);
- private static final SerializableRunnableIF NO_OP =
mock(SerializableRunnableIF.class);
+ private static final SerializableRunnableIF NO_OP = new
DummySerializableRunnableIF();
Review comment:
Just curious - what as wrong with the previous approach to use a mock?
##########
File path: geode-memcached/build.gradle
##########
@@ -1,31 +1,30 @@
/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
*/
apply from: "${rootDir}/${scriptDir}/standard-subproject-configuration.gradle"
apply from: "${project.projectDir}/../gradle/publish-java.gradle"
dependencies {
- compileOnly(platform(project(':boms:geode-all-bom')))
- compileOnly('com.github.stephenc.findbugs:findbugs-annotations')
+ api(platform(project(':boms:geode-all-bom')))
+ api('com.github.stephenc.findbugs:findbugs-annotations')
Review comment:
Why did this get turned into an API dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
