jchen21 commented on a change in pull request #6351:
URL: https://github.com/apache/geode/pull/6351#discussion_r696124903
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
##########
@@ -1115,6 +1116,11 @@ public void unlockDiskStore(String diskStoreName) {
}
+ @Override
+ public boolean hasMemberOlderThan(KnownVersion version) {
+ return false;
Review comment:
Should this throw `UnsupportedOperationException`?
##########
File path: geode-docs/tools_modules/lucene_integration.html.md.erb
##########
@@ -334,6 +334,7 @@ Lucene indexes created for all members.
# <a id="LuceneRandC" class="no-quick-link"></a>Requirements and Caveats
- Join queries between regions are not supported.
+- All cluster members must be running the same minor version in order to
execute Lucene queries.
Review comment:
Are you talking about the same minor version of Lucene or same minor
version of Geode?
##########
File path:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java
##########
@@ -81,6 +82,10 @@ protected boolean process(final List<AsyncEvent> events) {
Boolean initialPdxReadSerialized =
this.cache.getPdxReadSerializedOverride();
cache.setPdxReadSerializedOverride(true);
+ if (cache.hasMemberOlderThan(KnownVersion.GEODE_1_15_0)) {
+ return false;
Review comment:
Better log something here before returning `false`. e.g. member version
or Lucene version etc. Otherwise from the user's point of view, it is hard to
figure out why the listener fails.
##########
File path:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java
##########
@@ -102,6 +103,12 @@ protected IndexRepository
finishComputingRepository(Integer bucketId, LuceneSeri
if (oldRepository != null) {
oldRepository.cleanup();
}
+
+ if (userRegion.getCache() != null
+ &&
userRegion.getCache().hasMemberOlderThan(KnownVersion.GEODE_1_15_0)) {
+ return null;
Review comment:
Better log something here before returning `null`. e.g. member version
or Lucene version mismatch etc. There are quite a few cases in this method that
return `null`. Then the caller might just return `BucketNotFoundException`, it
is hard to figure out what the real root cause is without additional
information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
