jvarenina commented on a change in pull request #6036:
URL: https://github.com/apache/geode/pull/6036#discussion_r696389252
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java
##########
@@ -158,10 +158,18 @@ public void
testPartitionedRegionWithPersistentGatewaySender() {
LogWriterUtils.getLogWriter().info("Started the senders");
- vm2.invoke(
- () -> WANTestBase.createPartitionedRegion(getTestMethodName(), null,
1, 100, isOffHeap()));
- vm3.invoke(
- () -> WANTestBase.createPartitionedRegion(getTestMethodName(), null,
1, 100, isOffHeap()));
+ AsyncInvocation inv1 = vm2.invokeAsync(() -> WANTestBase
+ .createPersistentPartitionedRegion(getTestMethodName(), null, 1, 100,
isOffHeap()));
+ AsyncInvocation inv2 = vm3.invokeAsync(() -> WANTestBase
+ .createPersistentPartitionedRegion(getTestMethodName(), null, 1, 100,
isOffHeap()));
+ try {
+ inv1.join();
+ inv2.join();
+
+ } catch (InterruptedException e) {
+ e.printStackTrace();
+ fail();
+ }
Review comment:
Hi @albertogpz ,
it seems that in this case it is not needed to create region in asynchronous
way, because persistent buckets are not recovered from persistent storage. Not
sure why I change it in the first place. Thanks, I will revert this change also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
