jdeppe-pivotal commented on a change in pull request #6794:
URL: https://github.com/apache/geode/pull/6794#discussion_r698819670



##########
File path: 
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSet.java
##########
@@ -383,6 +387,44 @@ long zrevrank(byte[] member) {
     return null;
   }
 
+  long zunionstore(RegionProvider regionProvider, RedisKey key, List<RedisKey> 
sourceSets,

Review comment:
       OK, so I introduced a `ZKeyWeight` class that does this. It's plumbed 
through from the executor, but the executor code still creates 2 separate lists 
of source sets and weights and then combines those into a `List<ZKeyWeight>`. I 
couldn't come up with an elegant way to parse the argument list directly into 
this structure. Suggestions are welcome!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to