albertogpz opened a new pull request #6825: URL: https://github.com/apache/geode/pull/6825
As of Kirk's comments: - Have a new ThreadExecutor in ClusterOperationExecutors to be used by the command which should be properly shutdown when the cache is stopped. - Allow passing a ThreadExecutor to the command for testing - Remove all but one of the mocked methods of WanCopyRegionFunction in the unit tests. - Extract ConnectionStatus nested class from WanCopyRegionFunction and create a factory that can be passed to the class to add the possibility to have other implementations for testing. - Added static method to get current executions running in WanCopyRegionFunction to be used in tests in order to avoid sleeps that make tests flaky. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to [email protected]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
