jdeppe-pivotal commented on a change in pull request #6826:
URL: https://github.com/apache/geode/pull/6826#discussion_r701465174
##########
File path:
geode-apis-compatible-with-redis/src/distributedTest/java/org/apache/geode/redis/SSLDUnitTest.java
##########
@@ -87,8 +87,9 @@ public void
givenMutualAuthentication_clientErrorsWithoutKeystore() throws Excep
// Create the client without a keystore
try (Jedis jedis = createClient(false, false)) {
- assertThatThrownBy(jedis::ping)
- .hasMessageContaining("readHandshakeRecord");
+ assertThatThrownBy(jedis::ping).satisfiesAnyOf(
+ e -> assertThat(e.getMessage()).contains("SSLException"),
+ e -> assertThat(e.getMessage()).contains("SSLHandshakeException"));
Review comment:
The top level exception is always `JedisConnectionException` and the
ones here are somewhere in the stack but not even the root cause. That's why
I'm just looking at the message since that always contains one of these. I also
have a strong suspicion that different plaforms and/or JDK produce slightly
different messages or exception stacks. This seems to be one way to cover all
bases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
