mmartell commented on a change in pull request #862:
URL: https://github.com/apache/geode-native/pull/862#discussion_r701534899
##########
File path: clicache/src/CacheTransactionManager.cpp
##########
@@ -33,111 +33,165 @@ namespace Apache
void CacheTransactionManager::Begin( )
{
- _GF_MG_EXCEPTION_TRY2
-
+ try {
m_nativeptr->begin( );
-
- _GF_MG_EXCEPTION_CATCH_ALL2
+ }
+ catch (const apache::geode::client::Exception& ex) {
+ throw Apache::Geode::Client::GeodeException::Get(ex);
+ }
+ catch (System::AccessViolationException^ ex) {
+ throw ex;
+ }
}
void CacheTransactionManager::Prepare( )
{
- _GF_MG_EXCEPTION_TRY2
-
+ try {
Review comment:
We don't currently use any lambdas in C++/CLI code. It's not clear to me
if it is even supported. Possibly for unmanaged code I believe you are
indicating. However, for this PR I'm not sure it's with introducing new
features in a deprecated compiler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
