dschneider-pivotal commented on a change in pull request #6814:
URL: https://github.com/apache/geode/pull/6814#discussion_r703811118
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/pubsub/AbstractSubscription.java
##########
@@ -26,33 +28,34 @@
import org.apache.geode.redis.internal.netty.Client;
import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+
public abstract class AbstractSubscription implements Subscription {
private static final Logger logger = LogService.getLogger();
- private final Client client;
- private final ExecutionHandlerContext context;
+ private final ExecutionHandlerContext context;
+ private final byte[] subscriptionName;
// Before we are ready to publish we need to make sure that the response to
the
// SUBSCRIBE command has been sent back to the client.
private final CountDownLatch readyForPublish = new CountDownLatch(1);
- private final Subscriptions subscriptions;
private boolean running = true;
- AbstractSubscription(Client client, ExecutionHandlerContext context,
- Subscriptions subscriptions) {
- if (client == null) {
- throw new IllegalArgumentException("client cannot be null");
- }
+ AbstractSubscription(ExecutionHandlerContext context,
+ Subscriptions subscriptions, byte[] subscriptionName) {
if (context == null) {
throw new IllegalArgumentException("context cannot be null");
}
if (subscriptions == null) {
throw new IllegalArgumentException("subscriptions cannot be null");
}
- this.client = client;
+ if (subscriptionName == null) {
+ throw new IllegalArgumentException("subscriptionName cannot be null");
+ }
Review comment:
I removed the checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
