dschneider-pivotal commented on a change in pull request #6844:
URL: https://github.com/apache/geode/pull/6844#discussion_r704605950
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java
##########
@@ -1317,7 +1317,7 @@ static Class _getAttributeType(String attName) {
"Specifies the address on which the Redis API for Geode is listening.
If set to the empty string or this property is not specified, localhost is
requested from the operating system.");
m.put(REDIS_ENABLED,
"When the default value of false, the Redis API for Geode is not
available. Set to true to enable the Redis API for Geode.");
- m.put(REDIS_PASSWORD,
+ m.put(REDIS_USERNAME,
"Specifies the password that the server uses when a client attempts to
authenticate. The default is none and no authentication will be required.");
Review comment:
this help string needs to be updated. It is still describing the old
password property
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java
##########
@@ -3515,24 +3515,24 @@ static InetAddress _getDefaultMcastAddress() {
boolean DEFAULT_REDIS_ENABLED = false;
/**
- * Returns the value of the {@link ConfigurationProperties#REDIS_PASSWORD}
property
+ * Returns the value of the {@link ConfigurationProperties#REDIS_USERNAME}
property
* <p>
* Returns the value of the
- * {@link ConfigurationProperties#REDIS_PASSWORD} property
+ * {@link ConfigurationProperties#REDIS_USERNAME} property
*
* @return the authentication password for GeodeRedisServer
Review comment:
update comment to refer to username
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartServerCommand.java
##########
@@ -290,7 +290,7 @@ ResultModel doStartServer(String memberName, Boolean
assignBuckets, String bindA
redisPort);
StartMemberUtils.setPropertyIfNotNull(gemfireProperties,
ConfigurationProperties.REDIS_BIND_ADDRESS, redisBindAddress);
- StartMemberUtils.setPropertyIfNotNull(gemfireProperties,
ConfigurationProperties.REDIS_PASSWORD,
+ StartMemberUtils.setPropertyIfNotNull(gemfireProperties,
ConfigurationProperties.REDIS_USERNAME,
redisPassword);
Review comment:
change "redisPassword" to "redisUsername"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
