mhansonp commented on a change in pull request #6764:
URL: https://github.com/apache/geode/pull/6764#discussion_r705621673
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/ha/HARegionQueue.java
##########
@@ -2318,7 +2310,7 @@ private int reconcilePutPermits() {
@Override
void incrementTakeSidePutPermitsWithoutNotify() {
synchronized (this.permitMon) {
Review comment:
The permitmon is what provides the waiting mechanism when the queue is
full at 20,000 without it, it overfills the hrq to 100,000 when the limit is
set to 10,000. And the hrq.region.size goes to 200,000 when it should be
20,000. I think we should keep permit mon. All of the other changes look good
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
