DonalEvans commented on a change in pull request #6831:
URL: https://github.com/apache/geode/pull/6831#discussion_r706505532
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisHash.java
##########
@@ -243,10 +243,9 @@ public int hstrlen(byte[] field) {
throw new IllegalArgumentException("Requested array size exceeds VM
limit");
}
List<byte[]> resultList = new ArrayList<>((int) maximumCapacity);
- do {
- cursor = hash.scan(cursor, 1,
- (list, key, value) -> addIfMatching(matchPattern, list, key, value),
resultList);
- } while (cursor != 0 && resultList.size() < maximumCapacity);
+
+ cursor = hash.scan(cursor, count,
+ (list, key, value) -> addIfMatching(matchPattern, list, key, value),
resultList);
Review comment:
That's the behaviour that Redis has. See this comment:
https://github.com/apache/geode/pull/6831#discussion_r702144208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
