dschneider-pivotal commented on a change in pull request #6783: URL: https://github.com/apache/geode/pull/6783#discussion_r707477991
########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/delta/ZAddsDeltaInfo.java ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + * + */ + +package org.apache.geode.redis.internal.delta; + +import static org.apache.geode.redis.internal.delta.DeltaType.ZADDS; + +import java.io.DataOutput; +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; + +import org.apache.geode.DataSerializer; + +public class ZAddsDeltaInfo implements DeltaInfo { + private final List<byte[]> deltas; + private final double[] scores; + + public ZAddsDeltaInfo(int size) { + this.deltas = new ArrayList<>(); Review comment: presize the ArrayList by passing "size" to the constructor ########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZAddExecutor.java ########## @@ -50,8 +52,18 @@ public RedisResponse executeCommand(Command command, ExecutionHandlerContext con return RedisResponse.error(zAddExecutorState.exceptionMessage); } - Object retVal = redisSortedSetCommands.zadd(command.getKey(), - new ArrayList<>(commandElements.subList(optionsFoundCount + 2, commandElements.size())), + int size = (commandElements.size() - optionsFoundCount - 2) / 2; + List<byte[]> members = new ArrayList<>(size); + List<Double> scores = new ArrayList<>(size); Review comment: I still see "scores" is a List<Double>. You can change it double[] and change the "zadd" method to take a double[]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
