dschneider-pivotal commented on a change in pull request #6847:
URL: https://github.com/apache/geode/pull/6847#discussion_r707539115
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/StringBytesGlossary.java
##########
@@ -32,27 +32,37 @@
/**
* byte identifier of a bulk string
*/
- public static final byte BULK_STRING_ID = 36; // '$'
+ public static final byte BULK_STRING_ID = '$';
Review comment:
Is a java character literal's ordinal value stable? Or can it change
based on the locale? If you know the answer can you send a link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
