dschneider-pivotal commented on a change in pull request #6872:
URL: https://github.com/apache/geode/pull/6872#discussion_r710380885
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/KeyHashUtil.java
##########
@@ -35,7 +33,7 @@ public static short slotForKey(byte[] key) {
int endHashtag;
for (startHashtag = 0; startHashtag < key.length; startHashtag++) {
- if (key[startHashtag] == LEFT_BRACE_ID) {
+ if (key[startHashtag] == (byte) '{') {
Review comment:
I think all these casts of "(byte)" can be removed.
Given a variable of type "byte" named "b" you can do "b == '{'". I think
removing these will make the code a bit more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
