Bill commented on a change in pull request #6714:
URL: https://github.com/apache/geode/pull/6714#discussion_r708741605
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
##########
@@ -455,6 +455,12 @@ public void readExternal(ObjectInput in) throws
IOException, ClassNotFoundExcept
durableClientAttributes = null;
}
+ @Override
+ public void toDataPre_GEODE_1_15_0_0(DataOutput out, SerializationContext
context)
+ throws IOException {
+ memberIdentifier.toDataPre_GEODE_1_15_0_0(out, context);
+ }
+
Review comment:
sorry to be nitpicky but would you mind moving `toData()` so it's before
each of the version-specific to-data methods. The to-data methods should be
ordered in the source file from newest to oldest. I believe that's the pattern
established in other DSFIDs.
Ordering them consistently helps maintainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
