DonalEvans commented on a change in pull request #6899:
URL: https://github.com/apache/geode/pull/6899#discussion_r715117452
##########
File path:
geode-apis-compatible-with-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubNativeRedisAcceptanceTest.java
##########
@@ -15,30 +15,70 @@
package org.apache.geode.redis.internal.executor.pubsub;
-import org.apache.logging.log4j.Logger;
+import java.io.BufferedReader;
+import java.io.FileReader;
+import java.io.IOException;
+import java.io.InputStreamReader;
+
+import org.apache.commons.lang3.SystemUtils;
import org.junit.AfterClass;
+import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.apache.geode.NativeRedisTestRule;
-import org.apache.geode.logging.internal.log4j.api.LogService;
public class PubSubNativeRedisAcceptanceTest extends
AbstractPubSubIntegrationTest {
-
- private static final Logger logger = LogService.getLogger();
+ private static long socketTimeWaitMsec = 90000;
@ClassRule
public static NativeRedisTestRule redis = new NativeRedisTestRule();
+ @BeforeClass
+ public static void runOnce() throws IOException {
Review comment:
`IOException` is never thrown from this method.
##########
File path:
geode-apis-compatible-with-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubNativeRedisAcceptanceTest.java
##########
@@ -15,30 +15,70 @@
package org.apache.geode.redis.internal.executor.pubsub;
-import org.apache.logging.log4j.Logger;
+import java.io.BufferedReader;
+import java.io.FileReader;
+import java.io.IOException;
+import java.io.InputStreamReader;
+
+import org.apache.commons.lang3.SystemUtils;
import org.junit.AfterClass;
+import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.apache.geode.NativeRedisTestRule;
-import org.apache.geode.logging.internal.log4j.api.LogService;
public class PubSubNativeRedisAcceptanceTest extends
AbstractPubSubIntegrationTest {
-
- private static final Logger logger = LogService.getLogger();
+ private static long socketTimeWaitMsec = 90000;
@ClassRule
public static NativeRedisTestRule redis = new NativeRedisTestRule();
+ @BeforeClass
+ public static void runOnce() throws IOException {
+ if (SystemUtils.IS_OS_LINUX) {
+ try {
+ BufferedReader bufferedReader =
+ new BufferedReader(new
FileReader("/proc/sys/net/ipv4/tcp_fin_timeout"));
Review comment:
This might be better as a try-with-resources: `try(BufferedReader
bufferedReader = new BufferedReader(new
FileReader("/proc/sys/net/ipv4/tcp_fin_timeout"))) {`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
