demery-pivotal commented on pull request #6890: URL: https://github.com/apache/geode/pull/6890#issuecomment-926126850
> Great introduction of the pull request. Really appreciate that. Will this pull request introduce some temporary failures before another step 2 (re-implementing `GeodeParamsRunner`) pull request is introduced? I see there are quite a few failures in the CI `acceptance-test-openjdk11`. I'm confident that my PR did not cause the acceptance test failures, for these reasons: - None of the failed tests use `GeodeParamsRunner` or `JUnitParamsRunner`, so none of them were _directly_ affected by my PR. - Acceptance tests don't run in parallel, so my changes could not have interfered with the failed tests by inadvertently running some bogus test in parallel. - The exact same tests failed in another PR precheckin (http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-6893/test-results/acceptanceTest/1632358535/), which does not include my changes. - The "several gateway receivers" tests failed in another PR precheckin (http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-6891/test-results/acceptanceTest/1632349755/), which does not include my changes. - My PR did not change which tests are executed. My PR executed the exact same acceptance tests as another PR (https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-pr/jobs/acceptance-test-openjdk11/builds/1601), which does not include my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
